Enable Windows device tests on net7.0 #16756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
force-pushed
the
devicetests-net7
branch
from
9e813af
to
4599096
Compare
|
Apart from the failing test that is unrelated and a more general problem, this one is good now! |
This comment was marked as off-topic.
This comment was marked as off-topic.
* Build & Run Packaged Windows DeviceTests * Disable running for Core * Skip failing tests * Skip Launcher tests * Update Launcher_Tests.cs * Update windows.cake * Revert "Update windows.cake" This reverts commit f94dfdd. * Update windows.cake
* Fix WinUI test issues * - enable core tests * - core test fixes * - ignore semantics tests * - fix * - syntax errors
This reverts commit bec734e.
github-actions
bot
force-pushed
the
devicetests-net7
branch
from
4599096
to
b68ee8b
Compare
rmarinho
approved these changes
Aug 21, 2023
|
@jfversluis seems this is failing on net7 also on iOS , so I think this is good to merge. |
samhouts
approved these changes
Aug 22, 2023
jfversluis
added a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This brings #15629 and #15885 to net7.0 as well and enabled running the device tests on Windows for the .NET 7 branch. This has already been enabled for the main branch (currently .NET 8)